Comments on: How to write a singleton class in javascript http://www.javascriptkata.com/2009/09/30/how-to-write-a-singleton-class-in-javascript/ Advanced katas for javascripters Fri, 30 Jul 2010 18:10:52 +0000 hourly 1 http://wordpress.org/?v=3.0 By: mrathsfeld http://www.javascriptkata.com/2009/09/30/how-to-write-a-singleton-class-in-javascript/comment-page-1/#comment-928 mrathsfeld Mon, 05 Jul 2010 20:24:04 +0000 http://www.javascriptkata.com/?p=166#comment-928 This implementation is broken! <br><br>The scope of the getInstance() function is Window. Therefore this.singletonInstance is actually Window.singletonInstance aka a super global. (This can be easily verified with Firebug.)<br><br>Applying this implementation to multiple classes will result in all classes returning the same object! This implementation is broken!

The scope of the getInstance() function is Window. Therefore this.singletonInstance is actually Window.singletonInstance aka a super global. (This can be easily verified with Firebug.)

Applying this implementation to multiple classes will result in all classes returning the same object!

]]> By: simaopig http://www.javascriptkata.com/2009/09/30/how-to-write-a-singleton-class-in-javascript/comment-page-1/#comment-907 simaopig Wed, 05 May 2010 17:54:09 +0000 http://www.javascriptkata.com/?p=166#comment-907 It's nice singleton demo.<br><br>And it is a lazy loading type. Very nice. It's nice singleton demo.

And it is a lazy loading type. Very nice.

]]> By: KooiInc http://www.javascriptkata.com/2009/09/30/how-to-write-a-singleton-class-in-javascript/comment-page-1/#comment-849 KooiInc Mon, 23 Nov 2009 17:02:42 +0000 http://www.javascriptkata.com/?p=166#comment-849 You could rewrite this (for more efficiency): function Cats(){ var names = [], proto = arguments.callee.prototype; if (!proto._initiated){ proto.add = function(name) { names.push(name); return this.names(); }; proto.names = function() { return names; }; proto._initiated = true; } return this; } You could rewrite this (for more efficiency):

function Cats(){
var names = [],
proto = arguments.callee.prototype;
if (!proto._initiated){
proto.add = function(name) {
names.push(name);
return this.names();
};
proto.names = function() {
return names;
};
proto._initiated = true;
}
return this;
}

]]> By: trice22 http://www.javascriptkata.com/2009/09/30/how-to-write-a-singleton-class-in-javascript/comment-page-1/#comment-804 trice22 Mon, 05 Oct 2009 11:12:19 +0000 http://www.javascriptkata.com/?p=166#comment-804 Could you explain how this is supposed to be used? This doesn't do much: var foo = new Cats(); var bar = new Cats(); foo.add("Joe"); bar.add("Bert"); foo.names() // => ["Joe"] Cheers. Could you explain how this is supposed to be used?

This doesn’t do much:

var foo = new Cats();
var bar = new Cats();

foo.add(“Joe”);
bar.add(“Bert”);

foo.names() // => ["Joe"]

Cheers.

]]> By: How to make a singleton in javascript | Javascript Kata http://www.javascriptkata.com/2009/09/30/how-to-write-a-singleton-class-in-javascript/comment-page-1/#comment-800 How to make a singleton in javascript | Javascript Kata Thu, 01 Oct 2009 15:10:29 +0000 http://www.javascriptkata.com/?p=166#comment-800 [...] How to make a singleton in javascript April 4, 2007 by Dan Simard black belt, object-oriented | 23 comments [UPDATE : This post is outdated. Check out the new post on singletons.] [...] [...] How to make a singleton in javascript April 4, 2007 by Dan Simard black belt, object-oriented | 23 comments [UPDATE : This post is outdated. Check out the new post on singletons.] [...]

]]> By: JavaScript Countdown Timer http://www.javascriptkata.com/2009/09/30/how-to-write-a-singleton-class-in-javascript/comment-page-1/#comment-798 JavaScript Countdown Timer Thu, 01 Oct 2009 03:20:09 +0000 http://www.javascriptkata.com/?p=166#comment-798 very cool & good tip, thank you very much for sharing. Can I <a href="http://www.javascriptbank.com/submit/" rel="nofollow">share this snippet</a> on my JavaScript library? Awaiting your response. Thank very cool & good tip, thank you very much for sharing.

Can I share this snippet on my JavaScript library?

Awaiting your response. Thank

]]>